Merged
Conversation
Jan-Schuppik
force-pushed
the
support-php-8.4/8.5
branch
from
6dd12c0 to
bfcf494
Compare
Contributor
sukhwinder33445
requested changes
Jan 13, 2026
sukhwinder33445
force-pushed
the
support-php-8.4/8.5
branch
from
d03f498 to
089286d
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sukhwinder33445
previously approved these changes
Jan 15, 2026
Member
|
@Jan-Schuppik Please rebase. |
Jan-Schuppik
force-pushed
the
support-php-8.4/8.5
branch
from
089286d to
a85959e
Compare
2 tasks
PHP 8.4 deprecates implicitly nullable parameter declarations, meaning that declaring a function or method parameter with a default value of `null` without explicitly marking the type as nullable (using `?Type`) will trigger a deprecation notice: https://www.php.net/manual/en/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter
`PDO::MYSQL_ATTR_INIT_COMMAND` is deprecated as of PHP 8.5 and should be replaced with `Pdo\Mysql::ATTR_INIT_COMMAND`: https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.pdo
`SplObjectStorage` methods `attach()`, `contains()`, and `detach()` are deprecated in PHP 8.5. Since these methods are aliases for the methods `offsetSet()`, `offsetExists()` and `offsetUnset()` of the `ArrayAccess` interface implemented by `SplObjectStorage`, they can safely be replaced by these equivalents: https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.spl
In PHP 8.5, `null` can no longer be used as an array key. Previously, `null` was automatically converted to an empty string (`''`), but this behavior is now deprecated: https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.core.using-null-as-an-array-offset
lippserd
force-pushed
the
support-php-8.4/8.5
branch
from
a85959e to
dc9b261
Compare
The package has been migrated to `reac/async`. Use that instead.
lippserd
force-pushed
the
support-php-8.4/8.5
branch
from
dc9b261 to
c5de5e6
Compare
lippserd
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 changes:
nullby default must be declared nullable.PHP 8.5 changes:
SplObjectStorage.nullas an array offset is deprecated.PDO::MYSQL_ATTR_INIT_COMMAND.Other changes:
clue/block-reactwithreact/async.resolves #437